Compare commits

...

2 Commits

Author SHA1 Message Date
bincxz
986f552779 Closes settings window with main window exit
Some checks failed
build-packages / build-windows-latest (push) Has been cancelled
build-packages / build-macos-latest (push) Has been cancelled
build-packages / release (push) Has been cancelled
Ensures the settings window closes automatically when the main window is closed, preventing orphaned settings windows and improving overall window lifecycle management.
2026-01-07 00:35:01 +08:00
bincxz
42647e3572 Removes parent window assignment for settings window
Avoids rendering issues on macOS and prevents unintended main window closure on Windows by not assigning a parent window when opening the settings window.
2026-01-07 00:29:50 +08:00

View File

@@ -615,6 +615,8 @@ async function createWindow(electronModule, options) {
if (saveStateTimer) clearTimeout(saveStateTimer);
const state = getWindowBoundsState(win, lastNormalBounds);
if (state) saveWindowState(state);
// Close settings window when main window closes
closeSettingsWindow();
});
win.on("enter-full-screen", () => {
@@ -731,9 +733,10 @@ async function openSettingsWindow(electronModule, options) {
backgroundColor,
icon: appIcon,
fullscreenable: !isMac,
// NOTE: Do NOT set parent on Windows - it can cause the main window to close
// when the settings window is closed in some edge cases.
parent: isMac ? mainWindow : undefined,
// NOTE: Do NOT set parent - on macOS this causes rendering issues when dragging
// the window to a different screen (the window becomes invisible while still
// appearing in "Show All Windows" in the Dock). On Windows it can cause the
// main window to close when the settings window is closed.
modal: false,
show: false,
frame: isMac,